[Bug 75581] [next] remove tp_message_peek()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Feb 28 08:33:32 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=75581

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94842
  --> https://bugs.freedesktop.org/attachment.cgi?id=94842
echo-message-parts: use tp_message_dup_part()

Review of attachment 94842:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=75581&attachment=94842)
-----------------------------------------------------------------

::: examples/cm/echo-message-parts/chan.c
@@ +158,5 @@
>        if (s != NULL)
>          tp_message_set_string (received, j, "lang", s);
>  
> +      value = g_variant_dict_lookup_value (&dict, "content",
> +          G_VARIANT_TYPE_STRING);

Nitpicking: this doesn't copy binary content (it can either be an 's' or an
'ay'; iirc the latter was originally to support vCard over MMS, which sends a
binary blob of unspecified encoding, containing embedded charset tags analogous
to HTML <meta name="charset">).

I think that's fine for example code, though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list