[Bug 70990] [1.0] Logger parallel-installability

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70990

--- Comment #23 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 91985
  --> https://bugs.freedesktop.org/attachment.cgi?id=91985
implement the empathy store using the XML store directly

Review of attachment 91985:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=70990&attachment=91985)
-----------------------------------------------------------------

::: telepathy-logger/log-store-pidgin.c
@@ +93,4 @@
>          g_value_set_boolean (value, TRUE);
>          break;
>        case PROP_WRITABLE:
> +        g_value_set_boolean (value, self->priv->writable);

Why does this patch make log-store-pidgin potentially writable?

::: telepathy-logger/log-store-sqlite.c
@@ +119,4 @@
>          break;
>  
>        case PROP_WRITABLE:
> +        g_value_set_boolean (value, priv->writable);

I can see that there's value in being able to make a sqlite store read-only,
but it should be mentioned in the commit message, which currently implies that
only the XML store got this treatment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.