[Bug 70990] [1.0] Logger parallel-installability

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70990

--- Comment #30 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #23)
> Comment on attachment 91985 [details] [review]
> implement the empathy store using the XML store directly
> 
> Review of attachment 91985 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: telepathy-logger/log-store-pidgin.c
> @@ +93,4 @@
> >          g_value_set_boolean (value, TRUE);
> >          break;
> >        case PROP_WRITABLE:
> > +        g_value_set_boolean (value, self->priv->writable);
> 
> Why does this patch make log-store-pidgin potentially writable?
> 
> ::: telepathy-logger/log-store-sqlite.c
> @@ +119,4 @@
> >          break;
> >  
> >        case PROP_WRITABLE:
> > +        g_value_set_boolean (value, priv->writable);
> 
> I can see that there's value in being able to make a sqlite store read-only,
> but it should be mentioned in the commit message, which currently implies
> that only the XML store got this treatment.

I just naively implemented the property in each implementation of the log store
interface, wich requires a setting function as the property is write only.
Actually I'm wondering if it wouldn't be easier/cleaner to turn the store iface
to a base class so it could implement the property itself, saving us to do it
in each store. What do you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.