[Bug 69430] Make NewChannels, etc., singular?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69430

--- Comment #47 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #45)
> > - tp_tests_add_channel_to_ptr_array
> 
> Can that function be removed entirely?

Yes, removed.

> + g_object_notify ((GObject *) self, "channel");
> +
> + if (g_hash_table_lookup (self->priv->immutable_properties,
> + TP_PROP_CHANNEL_DISPATCH_OPERATION_CHANNEL) == NULL)
> + {
> + g_hash_table_insert (self->priv->immutable_properties,
> + g_strdup (TP_PROP_CHANNEL_DISPATCH_OPERATION_CHANNEL),
> + tp_g_value_slice_new_boxed (DBUS_TYPE_G_OBJECT_PATH, path));
> + }
> +
> + if (g_hash_table_lookup (self->priv->immutable_properties,
> + TP_PROP_CHANNEL_DISPATCH_OPERATION_CHANNEL_PROPERTIES) == NULL)
> + {
> + g_hash_table_insert (self->priv->immutable_properties,
> + g_strdup (TP_PROP_CHANNEL_DISPATCH_OPERATION_CHANNEL_PROPERTIES),
> + tp_g_value_slice_new_boxed (
> + TP_HASH_TYPE_STRING_VARIANT_MAP, properties));
> + }
> +}
> 
> Shouldn't we be updating internal state *before* emitting signals?

Technically the "channel" property is just self->priv->channel which has just
been updated. I just implemented the same logic as in 
maybe_set_connection() and maybe_set_account() but yeah, I can move all their
g_object_notify() if you prefer.

> > RequestableChannelClasses has been moved to Connection
> 
> I think you still need to update the client API to match?

Good catch; this wasn't properly tested so I missed it. I added an extra test.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.