[Bug 69430] Make NewChannels, etc., singular?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69430

--- Comment #51 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #50)
> New patches look good so far (up to 4d2ba2ae3), assuming you apply the
> "fixup!" before merging.

I squashed it now you reviewed it.

(In reply to comment #48)
> (In reply to comment #47)
> > Technically the "channel" property is just self->priv->channel which has
> > just been updated. I just implemented the same logic as in 
> > maybe_set_connection() and maybe_set_account() but yeah, I can move all
> > their g_object_notify() if you prefer.
> 
> I'd be OK with just moving that one g_object_notify to be after updating the
> object-path and immutable properties - yes in theory "channel" literally
> only means self->priv->channel, but I think there's value in having those
> closely-related things (appear to API users to) update simultaneously.

done.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.