[Bug 74185] New: MC can take its o.fd.T.AccountManager name too early
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Wed Jan 29 06:19:07 PST 2014
https://bugs.freedesktop.org/show_bug.cgi?id=74185
Priority: medium
Bug ID: 74185
Keywords: patch
Assignee: simon.mcvittie at collabora.co.uk
Summary: MC can take its o.fd.T.AccountManager name too early
QA Contact: telepathy-bugs at lists.freedesktop.org
Severity: normal
Classification: Unclassified
OS: All
Reporter: simon.mcvittie at collabora.co.uk
Hardware: Other
Status: ASSIGNED
Version: git master
Component: mission-control
Product: Telepathy
McdLoadAccountsData was being used for two separate things: either
the initial setup process for the AccountManager (not specific to an
account, blocking taking the AccountManager name) or the setup process
for an account being added by a storage plugin later on (specific to
an account, and hopefully after the AccountManager name has been taken).
Since release_load_accounts_lock() takes the AccountManager name in an
idempotent way, this happened to work most of the time. However,
if a storage plugin signals the addition of an account not in the
initial batch, and adding that account finishes before the setup
process for the initial batch, we'd take the name too early, and have
our D-Bus API before we should - that'd be bad.
Redo this so it makes more sense. We don't actually need a struct
for the "initial batch" case, because the McdAccountManager and maybe
a MigrateCtx is enough; just keep a count of locks in
McdAccountManagerPrivate.
--
You are receiving this mail because:
You are the QA Contact for the bug.
More information about the telepathy-bugs
mailing list