[Bug 27727] account storage plugins can contain partial accounts

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 29 11:45:14 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=27727

--- Comment #54 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Re-re-rebased this... tests pass after each commit now (assuming "fixup!"
commits are squashed).

http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=account-rework-27727-round4

Commits that have not been reviewed are:

*
http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=a3521e21d9534bb169c4d5361537656af3b06376
fixes a compiler warning and is to be squashed into the previous

*
http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=5633f3ae27a762444bb7a487abfd1f4b2aeacbaf
fixes a compiler warning and is to be squashed into the previous

*
http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=026cbb87190680f53a9a3382ed65f6e31cd9a4e5
fixes a compiler error and is to be squashed into the previous

*
http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=8e5e39aa29a833be16598b2392539af07808a85d
needed to be amended while rebasing

* so did
http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=e7ba5a86df4e90ec334a4c8ff9a11f9305458e00

* commits since Xavier's "Be consistent in the constness of arguments" are new

The first two of those were fixed in one of Xavier's extra commits, but I moved
them earlier in the branch.

It would be good if Xavier could look at
<http://cgit.freedesktop.org/~smcv/telepathy-mission-control/commit/?h=account-rework-27727-round4&id=eb7dc4a25c602de15f87fc63f56610ba5a7a05f8>
and opine whether that rewritten commit message is enough to satisfy Comment
#47. (No logic change, as described in Comment #49.)

My next thing on this topic is hopefully going to be Bug #71093.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list