[Bug 55104] Provide GVariant-based access to TpCallChannel:state-details

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55104

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 94834
  --> https://bugs.freedesktop.org/attachment.cgi?id=94834
TpFileTransferChannel: store metadata as a GVariant

Review of attachment 94834:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=55104&attachment=94834)
-----------------------------------------------------------------

::: telepathy-glib/file-transfer-channel.c
@@ +614,5 @@
>       TP_PROP_CHANNEL_INTERFACE_FILE_TRANSFER_METADATA1_METADATA,
>       TP_HASH_TYPE_METADATA);
>  
> +  if (metadata == NULL)
> +    self->priv->metadata = g_variant_new ("a{ss}", NULL);

a{sas}. Also, please sink the floating ref.

@@ +619,3 @@
>    else
> +    self->priv->metadata = _tp_boxed_to_variant (TP_HASH_TYPE_METADATA,
> +        "a{sas}", metadata);

Sink the floating ref. (You could add one unconditional line that sinks both,
maybe.)

@@ +1004,2 @@
>        "Metadata",
>        "The Metadata.Metadata property of this channel",

I'd prefer "... as a variant of type a{sas}, i.e. map with string keys and
array-of-strings values" or something, unless gtk-doc already has special
knowledge about g_param_spec_variant()'s 4th argument (and perhaps even if it
does).

@@ +1649,1 @@
>   *   value of the #TpFileTransferChannel:metadata property

I'd prefer the type to be explicit here too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.