[Bug 49505] somewhat high-level API to add client channel filters

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49505

--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #9)
> I rebased and refreshed your patch:
> http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-channel-filter-49505

(Not reviewed)

> > This naming is obviously terrible; in next we should s/_object// and get rid
> > of the hash-table-based versions.
> 
> But we now have:
> 
> void tp_base_client_add_approver_filter (TpBaseClient *self,
>     GVariant *filter);
> 
> Maybe this one could be renamed add_approver_filter_variant() so
> {add,take}_filter() can be used for the higher level API.

Yes, makes sense!

> > > + * At the time of writing, file transfers with other types of target
> > > + * (like chatrooms) have not been implemented. If they are, they will
> > > + * use a different filter.
> > 
> > I'm not sure that FTs for anyone other than contacts make sense anyway, so
> > there's no point in being speculatively general here.
> 
> Agreed; removed.

Oh, I'd intended "there's no point in being speculatively general" as rationale
for having that text instead of taking a mostly-pointless TpEntityType
parameter :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.