[Bug 76175] [next] Create TpTLSCertificate objects using TpClientFactory

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76175

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #2)
>  - You're missing the _TP_AVAILABLE_IN_ for
> tp_client_factory_ensure_tls_certificate().
> 
>  - "Returns: (transfer full): a new TLS certificate proxy" --> "a reference
> to a" is better IMO, like others ensure_foo. I see you did the same for
> protocol.
> 
>  - tp_client_factory_ensure_tls_certificate() is missing the variant
> g_return_val_if_fail(). Like tp_proxy_get_factory(conn_or_chan) == self to
> be sure we don't mix proxies from different factories.

All fixed in both branches.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.