[Bug 28782] Migrate from dbus-glib to glib's GDBus

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Mar 17 04:44:50 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=28782

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #13)
> I just didn't understand how property getter/setter works service side.

I still implement each method of o.fd.DBus.Properties "the hard way" with
TpDBusPropertiesMixin, just like we did for dbus-glib.

For dbus-glib, we did that instead of using dbus-glib's own facilities because
dbus-glib incorrectly conflated GObject-level "access control" with D-Bus-level
"access control", which would have led to absurdities like being able to change
a channel's TargetHandle from D-Bus just because that GObject property was
marked READWRITE (and CONSTRUCT_ONLY, but dbus-glib didn't respect that).

I didn't realize when I worked around it, but that was actually an exploitable
security bug in certain system services, CVE-2010-1172.

For GDBus, it would be nice to be able to switch away from implementing
o.fd.DBus.Properties ourselves, but I haven't implemented it yet. I'd like to
make the Logger tests work, and port at least one connection manager, before
thinking too hard about what the "better than TpSvc" API should look like.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list