[Bug 76120] [next] preparatory cleanup for GDBus migration

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76120

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #4)
>  - "account-request test: don't leak account manager"

Added a whole stack of commits to make sure everything is freed
("tp_tests_await_last_unref: add" and everything newer than it).

>  - "tp_tests_proxy_run_until_dbus_queue_processed: don't use Introspect": I
> don't like that hack, but I've got no better idea to workaround. Let's hope
> a proper fix can go into GDBus.

No action taken.

>  - "account-request test: prepare account manager"

See above. I replaced this with a tp_tests_await_last_unref call.

>  - "_tp_channel_got_properties: if we were invalidated, don't continue"

No action taken.

>  - "tp_private_proxy_set_implementation: don't use g_assert_cmp* family":
> you can use g_str_equal() when you know both strings are non-NULL.

Done, there's a fixup commit just after the one you're commenting on.

>  - "stream-tube test: don't assume one event per main loop iteration": In
> create_tube_service() you should set test->tube_conns to NULL after
> g_list_free_full() I think.

Done, there's a fixup commit just after the one you're commenting on. I'd have
left it at the end of the branch, but it conflicts.

gdbus branch rebased onto it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.