[Bug 70990] [1.0] Logger parallel-installability

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70990

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #43 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #42)
> Not in tests/logger/Makefile.am, only in tests/logger/dbus/Makefile.am.

I fixed that.

> tests/logger/dbus/Makefile.am:   
> TPL_TEST_LOG_DIR=@abs_top_srcdir@/tests/logger/logs           \
> tests/logger/dbus/Makefile.am:   
> XDG_DATA_HOME=@abs_top_builddir@/tests/logger/logs            \

I fixed that; it should have been consistently the srcdir (tests failed without
this change, and pass with it).

> I wonder whether we should in fact be creating a temporary directory in the
> builddir, and copying the logs in from the srcdir before each test?

The tests that need write access already do that.

Pushed with those changes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.