[Bug 16891] Telepathy should support OTR encryption

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=16891

--- Comment #74 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #62)
> Corner cases:
> 
> What happens when we try to send a message and the channel is already
> TRUST_FINISHED? I think we should refuse, for the rest of the lifetime of
> that channel (until Close()), to avoid the security flaw where we send
> messages to a channel that just closed.

Just tested, OTR refuse to send and a message is displayed. 

"""
test3 at test.collabora.co.uk:  Your message was not sent because
test3 at test.collabora.co.uk closed their connection. Either close your private
connection, or refresh it.
"""

> What happens when we close a channel locally? I think the answer should be
> "we terminate the OTR session, and start from an unsecured state next time"
> - even if the channel is in fact going to respawn due to unacknowledged
> messages. This means the channel needs to reset its Encrypted flag, Verified
> flag and all OTR state when it respawns. We will still be able to tell the
> rescued messages were encrypted/verified because the header that I suggested
> adding will say so.

I don't end the otr session yet (adding a patch now to do that). pending
messages are already decrypted so user won't know if they were sent privately
or not. Indeed adding the fingerprint in the message parts can be helpful. otoh
I would consider this future enhancement, when a new chat window arrives if
there is no message telling its private the user should just assume it's not.
He can always start a new otr session and ask to repeat to be sure. IMO that's
corner case so it's not that bad if user needs to ask repeating.

> What happens if I'm talking to bob at example.com/Laptop using OTR, and I
> receive a message from bob at example.com/Phone without OTR? I hope the answer
> is "libotr deals with it and reports OTRL_MSGEVENT_RCVDMSG_UNENCRYPTED". Is
> it safe (as in, not a security vulnerability) to rely on that?

I didn't test what happens with multiple resources, tbh. But if for any reason
something unencrypted arrives, it raises OTRL_MSGEVENT_RCVDMSG_UNENCRYPTED.

> What happens when we receive a message and the channel is already
> TRUST_FINISHED? I hope the answer is "libotr deals with it and reports
> OTRL_MSGEVENT_RCVDMSG_UNENCRYPTED". Is it safe (as in, not a security
> vulnerability) to rely on that?

it does indeed raise OTRL_MSGEVENT_RCVDMSG_UNENCRYPTED.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.