[Bug 77882] TpBaseClient: stop implementing TpSvcAnything

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77882

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xclaesse at gmail.com

--- Comment #13 from Xavier Claessens <xclaesse at gmail.com> ---
"base-client: be a GDBusObjectSkeleton": +1

"base-client: use gdbus-codegen's skeleton to implement Observer":

 - update_interfaces() does more than updating interfaces now since it calls
observer_skeleton_init(). Also it can be called each time when unregister and
re-register and callding observer_skeleton_init() multiple times will leak
self->priv->observer_skeleton. What about inlining that function into
_register() and clear all skeletons in _unregister() ?

 - create_channel_request_array() is leaking key, "o" will dup key, you can use
"&o" instead to get internal "const gchar *".

 - in _tp_base_client_observe_channel() the requests_hash argument is not an
"hash" anymore, maybe rename to requests_variant ?



I didn't read the rest of the branch yet.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.