[Bug 77030] [1.0] check that ContactSearch has a sane RequestableChannelClasses entry now

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77030

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 98967
  --> https://bugs.freedesktop.org/attachment.cgi?id=98967
[tp-glib] allow CMs to put 'TargetEntityType=None' in contact search requests

Review of attachment 98967:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=77030&attachment=98967)
-----------------------------------------------------------------

Looks good, although a regression test would be nice.

::: telepathy-glib/capabilities.c
@@ +920,5 @@
>          continue;
>  
> +      entity_type = tp_vardict_get_uint32 (fixed,
> +          TP_PROP_CHANNEL_TARGET_ENTITY_TYPE, &valid);
> +      /* If TargetEntityType is missing we threat it as NONE */

treat

A threat is something rather different :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.