[Bug 77772] [next] TpBaseContactList GInterfaces: take vfunc arguments of the appropriate type

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77772

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #1)
> You mean that it should be:
> 
> typedef GStrv (*TpBaseContactListDupContactGroupsFunc) (
>     TpContactGroupListInterface *self,
>     TpHandle contact);
> 
> instead of:
> 
> typedef GStrv (*TpBaseContactListDupContactGroupsFunc) (
>     TpBaseContactList *self,
>     TpHandle contact);
> 
> ?
> 
> If yes, then I guess we should do this change for all the vfunc in this
> interface, don't we?

Yes. The pattern is, wherever we have

typedef Mushroom (*BadgerFunc) (Snake *self, ...);
                            //  ^^^^^
struct _BadgerInterface {
  ...
  BadgerFunc dance;
}

the vfunc's "self" parameter needs to be changed to match the dummy typedef for
the interface:

typedef Mushroom (*BadgerFunc) (Badger *self, ...);
                             // ^^^^^^
struct _BadgerInterface {
  ...
  BadgerFunc dance;
}

This might mean splitting up some of the typedefs that are currently shared
between interfaces, according to the type that their "self" parameter needs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.