[Bug 78744] Port misc CM-side code to gdbus-codegen

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78744

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=gdbus-all&id=999bb8479dbc6a21c72b5c927097969c2abeeecd

Can't we create the skeleton in _init() and so not break registering while
creating the object?

If not, add a g_return_if_fail() in tp_base_channel_register() checking that
the skeleton exist to catch migration bugs?


http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=gdbus-all&id=9d18ffa6de783ccf7ad13dfda68093ef7773a007

+    case PROP_N_CONNECTIONS:
you forgot the 'break'


http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=gdbus-all&id=279930af369137e22c4e5a61e1a3b7ea33b389bc

Is that really the proper way to do it or just a workaround for this gjs bug?

I'm not really familiar with the handle repos code so I'd prefer to let smcv
review those from a high level pov.

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=gdbus-all&id=179a0a50cc58cc384b15060f4643959d3c62f820

Please add a one line comment at the start of each file explaining what is
being demonstrated in the example.

Shouldn't the first one be in examples/client/js/ ? I'm not convinced this
example is that useful actually. examples/ is supposed to contain scripts
showing how to use the TP API to perform common tasks.
Here it relies on a fake CM (while the other examples can be used with real
connections) and use low level API users are not supposed to care about. And we
already have examples/client/js/contact-list.js displaying contacts.

The second example makes much more sense as it show how to write a simple CM in
JS.


http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=gdbus-all&id=01f8b280742a67260b4ea542127d761b56f8fda5

Why can't we have (transfer non) vfuncs?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.