[Bug 77773] TpHandleSet: supersede GArray<guint32> functions with GVariant<"au"> versions

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 16 05:07:29 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77773

--- Comment #28 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 99143
  --> https://bugs.freedesktop.org/attachment.cgi?id=99143
stop using tp_handle_set_to_array() in tests

Review of attachment 99143:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=77773&attachment=99143)
-----------------------------------------------------------------

::: tests/lib/contact-list-manager.c
@@ +431,5 @@
> +  gconstpointer arr;
> +  gsize len;
> +
> +  handles = tp_handle_set_to_variant (contacts);
> +  arr = g_variant_get_fixed_array (handles, &len, sizeof (TpHandle));

I prefer to sink floating refs before calling any other API on them (other than
"add to container" which sinks the floating ref), to make it clear what's going
on.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list