[Bug 79006] [next] Fix clang warnings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79006

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 99481
  --> https://bugs.freedesktop.org/attachment.cgi?id=99481
ensure that values received from callback are not NULL

Review of attachment 99481:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=79006&attachment=99481)
-----------------------------------------------------------------

::: telepathy-glib/account.c
@@ +3313,4 @@
>  {
>    GTask *task = user_data;
>  
> +  g_return_if_fail (out_Value);

This shouldn't be asserted until after @error has been checked?

::: telepathy-glib/base-room-config.c
@@ +759,4 @@
>    static TpDBusPropertiesMixinIfaceInfo *iface_info = NULL;
>    TpDBusPropertiesMixinPropInfo *prop_info;
>  
> +  g_return_val_if_fail (value != NULL, FALSE);

(unreviewed, I'll need to see more context)

::: telepathy-glib/connection.c
@@ +515,4 @@
>    TpConnection *self = (TpConnection *) proxy;
>    GSimpleAsyncResult *result;
>  
> +  g_return_if_fail (value != NULL);

Should not be asserted until @error has been checked

::: telepathy-glib/debug-client.c
@@ +268,4 @@
>  {
>    TpDebugClient *self = TP_DEBUG_CLIENT (proxy);
>  
> +  g_return_if_fail (value != NULL);

Likewise

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.