[Bug 79006] [next] Fix clang warnings

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon May 26 04:11:20 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=79006

--- Comment #16 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 99484
  --> https://bugs.freedesktop.org/attachment.cgi?id=99484
logger: don't assume @error is not NULL

Review of attachment 99484:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=79006&attachment=99484)
-----------------------------------------------------------------

::: telepathy-logger/log-store-xml.c
@@ +451,5 @@
>    bus_connection = g_bus_get_sync (G_BUS_TYPE_SESSION, NULL, error);
>    if (bus_connection == NULL)
>      {
> +      DEBUG ("Error acquiring bus connection: %s",
> +          error != NULL ? (*error)->message : "");

I'd prefer "(no GError available)" over "" as the fallback.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list