[Bug 77772] [next] TpBaseContactList GInterfaces: take vfunc arguments of the appropriate type

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77772

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
+ * It is an error to call this fonction if @self subclass does not implement

"function" (please git grep)

I think "if @self does not implement" would also be better.

All looks OK so far, apart from those comments.

(In reply to comment #7)
> Does this apply to tp_base_contact_list_can_block() as well which is
> explicitely used to check if the contact list support blocking?

Hmm. For now let's say "no, leave can_block() as-is" and see what the g-i looks
like.

If necessary we can change all its callers to

    (TP_IS_BLOCKABLE_CONTACT_LIST (cl) &&
     tp_blockable_contact_list_can_block ((TpBlockableContactList *) cl))

but that's pretty cumbersome...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.