[Bug 79006] [next] Fix clang warnings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79006

--- Comment #25 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 99861
  --> https://bugs.freedesktop.org/attachment.cgi?id=99861
ensure that values received from callback are not NULL

Review of attachment 99861:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=79006&attachment=99861)
-----------------------------------------------------------------

This one looks fine now.

::: telepathy-glib/account.c
@@ +3312,5 @@
>      GObject *weak_object)
>  {
>    GTask *task = user_data;
>  
> +  g_return_if_fail (error != NULL || value != NULL);

Much better

::: telepathy-glib/base-room-config.c
@@ +759,4 @@
>    static TpDBusPropertiesMixinIfaceInfo *iface_info = NULL;
>    TpDBusPropertiesMixinPropInfo *prop_info;
>  
> +  g_return_val_if_fail (value != NULL, FALSE);

I've looked at the context now, and yes it's correct

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.