[Bug 77772] [next] TpBaseContactList GInterfaces: take vfunc arguments of the appropriate type

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77772

--- Comment #13 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #12)
> (In reply to comment #11)
> >       <method name="can_block"
> >               c:identifier="tp_base_contact_list_can_block"
> 
> I think that g-i looks OK.
> 
> (In reply to comment #10)
> > More of this:
> > http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-
> > contact-list-iface-77772
> 
> I don't see any new commits there?

Is cgit being shit again? Here it show 9 commits (from
db6d23db0fda5fe91f30e1bb99b6120b423a98a3 to
444f4ab3ff429e36c1a31c199b323751b74ff1c8) on top of next.

> > http://cgit.collabora.com/git/user/cassidy/telepathy-gabble/log/?h=next-
> > contact-list-iface-77772
> 
> The Gabble changes look OK, assuming reasonable tp-glib changes.
> 
> One comment: casting "TpMutableContactList *base" to TpBaseContactList *
> seems confusing. Shouldn't it be called iface or mutable or something
> instead? (I would be happy for your answer to be "yes but it's too much
> diffstat to be worth it", though.)

Yeah I know, but I have been too lazy to change those. :p

> I assume Haze will also need updating?

Actually no, it doesn't use any of those API.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.