[Bug 85307] New: escape_as_identifier issues

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=85307

            Bug ID: 85307
           Summary: escape_as_identifier issues
           Product: Telepathy
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
          Assignee: telepathy-bugs at lists.freedesktop.org
          Reporter: agrover at redhat.com
        QA Contact: telepathy-bugs at lists.freedesktop.org

docstring starts with: "Escape the given string to be a valid D-Bus object path
or service name component, using a reversible encoding to ensure uniqueness."

1) Docstring should clarify that this is for "object path components" and
"service name components". It could be read as "object paths" (i.e. an entire
path) and "service name components".

2) Recommend replacing references to "service name" with "well-known bus name",
since this is what the dbus spec calls them.

3) Recommend specific functions escaping the two different things. The two
string types have different allowable characters: bus name additionally allows
'-', and object path component can start with [0-9], whereas bus name cannot.
This could lead to characters being escaped when they needn't be.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.