[Bug 89595] Logs with weird strings may causes SEGV when reloaded

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89595

--- Comment #2 from Debarshi Ray <rishi.is at lostca.se> ---
Comment on attachment 114349
  --> https://bugs.freedesktop.org/attachment.cgi?id=114349
logger: Better NULL checking in tpl_log_iter_xml_get_event

Review of attachment 114349:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=89595&attachment=114349)
-----------------------------------------------------------------

Thanks for tracking this down, Daniel. I am not a telepathy reviewer, but I did
write most of that file...

It would be better if we tried to skip the date with the faulty file and tried
the next one. Instead of completely bailing out.

::: telepathy-logger/log-iter-xml.c
@@ +80,5 @@
>            priv->events = _tpl_log_store_get_events_for_date (priv->store,
>                priv->account, priv->target, priv->type_mask,
>                (GDate *) priv->next_date->data);
> +          if (!priv->events)
> +            break;

Nitpick: priv->events == NULL

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.