[Bug 92153] [Patch] Account properties notify signals are dispatched before the account property is updated; presence, connection changes signal with nonsensical orderering.

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Dec 19 03:01:54 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=92153

--- Comment #8 from James Smith <smithjd15 at gmail.com> ---
The first patch doesn't for better or worse doesn't change the output
appreciably, so the problem must be elsewhere. The second patch does indicate
that some property reordering can provide better results.

Providing a PresenceChanging property change both before and after connection
and presence changes can provide a more workable solution for  clients, that
can wait for the last signalling account to affect a presence average change of
their own. This looks like something for which the spec could possibly be more
clear on implementation, e.g. always order PresenceChanging -before-
RequestedPresence property in the same AccountPropertyChanged, conversely, send
a separate AccountPropertyChanged with the PresenceChanging property -after-
the CurrentPresence property. Each individual connection manager could be
checked to see if this property is properly ordered and in separate
AccountPropertyChanged signals, though it already looks like a required
compensation in updateProperties().

For reference:
https://telepathy.freedesktop.org/spec/Account.html#Property:ChangingPresence

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list