[Bug 94031] Unit test failure: FAIL: wocky http-proxy-test

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94031

--- Comment #4 from diane at ghic.org ---
George Kiagiadakis found that wocky-http-proxy was modified and became part of
gio as https://git.gnome.org/browse/glib/plain/gio/ghttpproxy.c

Diffing wocky-http-proxy and ghttpproxy shows a few meaningful differences.

Without the above patch I get errors like this:

ERROR:wocky-http-proxy-test.c:229:server_thread: assertion failed (base64_cred
== received_cred): ("QWxhZGRpbjpvcGVuIHNlc2FtZQ==" == "Basic
QWxhZGRpbjpvcGVuIHNlc2FtZQ==")

wocky-http-proxy.c (-) used a hard coded "Basic", while the ghttpproxy.c (+)
includes "Basic " as part of the credential

@@ -111,9 +97,9 @@
       cred = g_strdup_printf ("%s:%s", username, password);
       base64_cred = g_base64_encode ((guchar *) cred, strlen (cred));
       g_free (cred);
       g_string_append_printf (request,
-                              "Proxy-Authorization: Basic %s\r\n",
+          "Proxy-Authorization: %s\r\n",
                               base64_cred);
       g_free (base64_cred);
     }

The other solution might be to be drop the wocky-http-proxy, and update the
wocky-proxy tests to be compatible with giohttpproxy

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.