[Bug 96796] New: wocky tests were not updated for SCRAM-SHA-1 support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=96796

            Bug ID: 96796
           Summary: wocky tests were not updated for SCRAM-SHA-1 support
           Product: Wocky
           Version: git master
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: General
          Assignee: telepathy-bugs at lists.freedesktop.org
          Reporter: diane at ghic.org
        QA Contact: telepathy-bugs at lists.freedesktop.org

A number of wocky-connector-tests fail because the digest method used by wocky
is SCRAM-SHA-1, and the tests assume DIGEST-MD5.

for example:

  /connector/tls+auth/insecure/no-tlsplain/tls/digest:                 **
wocky-connector-test:ERROR:wocky-connector-test.c:3577:run_test: assertion
failed (test->result.mech == test->result.used_mech): ("DIGEST-MD5" ==
"SCRAM-SHA-1")
FAIL

In addition with SCRAM-SHA-1 enabled there are also errors like this:

  /connector/problem/sasl/bad-pass:                                    sasl
error (-5): SASL(-5): bad protocol / cancel: StoredKey mismatch
**
ERROR:wocky-test-sasl-auth-server.c:504:check_sasl_return: code should not be
reached
FAIL

Removing this block from wocky-auth-registry.c

  if (wocky_auth_registry_has_mechanism (mechanisms,
          WOCKY_AUTH_MECH_SASL_SCRAM_SHA_1))
    {
      if (out_handler != NULL)
        {
          /* XXX: check for username and password here? */
          DEBUG ("Choosing SCRAM-SHA-1 as auth mechanism");
          *out_handler = WOCKY_AUTH_HANDLER (wocky_sasl_scram_new (
              server, username, password));
        }
      return TRUE;
    }

allows both the DIGEST-MD5 and SASL bad user tests to pass.

Obviously changing the wocky-connector-tests.c to assuming SCRAM-SHA-1 makes
the non-sasl tests pass.

I'm currently stumped for how SASL is going wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.