[Bug 96707] telepathy-mission-control-5.16.3: fails to build/configure with recent NetworkManager versions unable to find libnm-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=96707

--- Comment #5 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
Comment on attachment 124774
  --> https://bugs.freedesktop.org/attachment.cgi?id=124774
Port to using the new nm 1 API

Review of attachment 124774:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=96707&attachment=124774)
-----------------------------------------------------------------

Looks good to me. It looks like it should work fine.

In addition to your changes, I would also now remove NM_CHECK_VERSION check on
line 205 and leave the "|| state == NM_STATE_DISCONNECTING" compile
unconditionally (as we no longer support older versions), and also remove the
NM_CHECK_VERSION definition on line 185-187 (this is to support even older
versions that don't have the NM_CHECK_VERSION macro in the headers)

::: src/connectivity-monitor.c
@@ +459,4 @@
>  mcd_connectivity_monitor_init (McdConnectivityMonitor *connectivity_monitor)
>  {
>    McdConnectivityMonitorPrivate *priv;
> +  GError *error;

GError pointers must be initialized to NULL before use.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.