[Bug 91671] [Patch] Specify unset presence type in PresenceSpec

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 17 10:56:16 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=91671

--- Comment #4 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
(In reply to James Smith from comment #3)
> Ideally, it would make sense to have all new presences created use
> this spec definition. Is there really any reason to return a
> Tp::ConnectionPresenceType of Unknown instead? Unknown seems to be only for
> unsubscribed contacts, not user set presences.

You are right about that. A an invalid PresenceSpec, created with the default
constructor, should return Unset instead of Unknown as its type. I will change
that in 1.0. Then we will only need a Presence::unknown() method and this will
cover it all. I think this is better than having a Presnce::unset() method, as
it kind of contradicts the spec (Unset vs Unknown).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list