[Bug 76401] memory leak from using dbus_g_method_get_sender wrong

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76401

George Kiagiadakis <gkiagia at tolabaki.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
         Whiteboard|review+                     |
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
Merged.

commit f576a9e8a125c16e3a562e3bb820707c1041af5c
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Thu Mar 20 12:53:39 2014 +0000

    dispatcher_delegate_channels: initialize am

    Otherwise, if we "goto error" too soon, we'll try to g_object_unref
    uninitialized memory. gcc doesn't spot that because we're using
    tp_clear_object, which uses an intermediate variable, and it doesn't
    propagate "uninitializedness" through assignments.

commit 43afd2866bc38efe1b2cf27989df4e36ddd21201
Author: Simon McVittie <simon.mcvittie at collabora.co.uk>
Date:   Thu Mar 20 12:51:18 2014 +0000

    fix memory leaks: dbus_g_method_get_sender returns a copy

    We were semi-consistently using it wrong.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.