[Bug 101646] New: should we transmit failed state to tp instead of exhausted candidates ?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101646

            Bug ID: 101646
           Summary: should we transmit failed state to tp instead of
                    exhausted candidates ?
           Product: Telepathy
           Version: git master
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-farstream
          Assignee: olivier.crete at ocrete.ca
          Reporter: fabrice at bellet.info
        QA Contact: telepathy-bugs at lists.freedesktop.org

I'm not sure of this case, but the code handling the conversion from
FS_STREAM_STATE_* to TP_STREAM_ENDPOINT_STATE_* looks a bit strange to me in
cb_fs_component_state_changed():

>  switch (fsstate)
>  {
>    default:
>      g_warning ("Unknown Farstream state, returning ExhaustedCandidates");
>      /* fall through */
>    case FS_STREAM_STATE_FAILED:
>      state = TP_STREAM_ENDPOINT_STATE_EXHAUSTED_CANDIDATES;
>      break;

Why is state EXHAUSTED_CANDIDATES returned in case of failure, instead of
TP_STREAM_ENDPOINT_STATE_FAILED ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.