[Telepathy-commits] [telepathy-gabble/master] roster: amend comments for GroupMembershipUpdate/GroupsUpdateContext to indicate where things are borrowed from

Simon McVittie simon.mcvittie at collabora.co.uk
Tue Aug 19 10:51:50 PDT 2008


20080423133603-53eee-e8612a4b2aabf07bb6b038e32f6fed8edefcae51.gz
---
 src/roster.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/roster.c b/src/roster.c
index 895c829..ec07535 100644
--- a/src/roster.c
+++ b/src/roster.c
@@ -515,16 +515,20 @@ typedef struct
 {
   /* borrowed TpHandle => GroupMembershipUpdate */
   GHashTable *group_mem_updates;
-  /* borrowed */
+  /* borrowed from the GabbleRosterItem */
   guint contact_handle;
 } GroupsUpdateContext;
 
 typedef struct
 {
-  /* all handles borrowed */
+  /* all contact handles borrowed from the corresponding GabbleRosterItem
+   * (but FIXME: if a contact disappears entirely, we may lose?) */
   TpIntSet *contacts_added;
   TpIntSet *contacts_removed;
 #ifdef ENABLE_DEBUG
+  /* This is also the key in the hash table in which these structs are values.
+   * Borrowed from the GabbleRosterItem's ->groups key (but FIXME: if all
+   * contacts have been removed from a particular group, we lose) */
   guint group_handle;
 #endif
 } GroupMembershipUpdate;
-- 
1.5.6.3




More information about the Telepathy-commits mailing list