When a CM falls off the bus, _tp_connection_clean_up_handle_refs tries to use a
DBusGConnection that's become NULL. The test simulates the CM falling off the
bus by emitting a spurious "destroy" signal on a connection proxy.
---
tests/dbus/Makefile.am | 3 +
tests/dbus/connection-bug-18845.c | 130 +++++++++++++++++++++++++++++++++++++
2 files changed, 133 insertions(+), 0 deletions(-)
create mode 100644 tests/dbus/connection-bug-18845.c
diff --git a/tests/dbus/Makefile.am b/tests/dbus/Makefile.am
index de2d725..621c23e 100644
--- a/tests/dbus/Makefile.am
+++ b/tests/dbus/Makefile.am
@@ -2,6 +2,7 @@ noinst_PROGRAMS = \
test-call-cancellation \
test-channel-introspect \
test-connection \
+ test-connection-bug-18845 \
test-connection-handles \
test-connection-inject-bug16307 \
test-connection-getinterfaces-failure \
@@ -28,6 +29,8 @@ test_channel_introspect_SOURCES = channel-introspect.c
test_connection_SOURCES = connection.c
+test_connection_bug_18845_SOURCES = connection-bug-18845.c
+
test_connection_handles_SOURCES = connection-handles.c
test_connection_inject_bug16307_SOURCES = connection-inject-bug16307.c
diff --git a/tests/dbus/connection-bug-18845.c b/tests/dbus/connection-bug-18845.c
new file mode 100644
index 0000000..2120c39
--- /dev/null
+++ b/tests/dbus/connection-bug-18845.c
@@ -0,0 +1,130 @@
+/* Regression test for https://bugs.freedesktop.org/show_bug.cgi?id=18845
+ *
+ * Copyright (C) 2008 Collabora Ltd. <http://www.collabora.co.uk/>
+ * Copyright (C) 2008 Nokia Corporation
+ *
+ * Copying and distribution of this file, with or without modification,
+ * are permitted in any medium without royalty provided the copyright
+ * notice and this notice are preserved.
+ */
+
+#include <telepathy-glib/connection.h>
+#include <telepathy-glib/dbus.h>
+#include <telepathy-glib/debug.h>
+#include <telepathy-glib/interfaces.h>
+#include <telepathy-glib/proxy-subclass.h>
+
+#include "tests/lib/myassert.h"
+#include "tests/lib/simple-conn.h"
+
+static int fail = 0;
+static GMainLoop *mainloop;
+
+static void
+myassert_failed (void)
+{
+ fail = 1;
+}
+
+static GError invalidated_for_test = { 0, TP_ERROR_PERMISSION_DENIED,
+ "No connection for you!" };
+
+static gboolean
+no_more_idling_around (gpointer data)
+{
+ g_main_loop_quit (data);
+ return FALSE;
+}
+
+int
+main (int argc,
+ char **argv)
+{
+ TpDBusDaemon *dbus;
+ SimpleConnection *service_conn;
+ TpBaseConnection *service_conn_as_base;
+ gchar *name;
+ gchar *conn_path;
+ GError *error = NULL;
+ TpConnection *conn;
+ DBusGProxy *proxy;
+
+ g_type_init ();
+ invalidated_for_test.domain = TP_ERRORS;
+
+ tp_debug_set_flags ("all");
+ mainloop = g_main_loop_new (NULL, FALSE);
+ dbus = tp_dbus_daemon_new (tp_get_bus ());
+
+ service_conn = SIMPLE_CONNECTION (g_object_new (
+ SIMPLE_TYPE_CONNECTION,
+ "account", "me at example.com",
+ "protocol", "simple",
+ NULL));
+ service_conn_as_base = TP_BASE_CONNECTION (service_conn);
+ MYASSERT (service_conn != NULL, "");
+ MYASSERT (service_conn_as_base != NULL, "");
+
+ MYASSERT (tp_base_connection_register (service_conn_as_base, "simple",
+ &name, &conn_path, &error), "");
+ MYASSERT_NO_ERROR (error);
+
+ conn = tp_connection_new (dbus, name, conn_path, &error);
+ MYASSERT (conn != NULL, "");
+ MYASSERT_NO_ERROR (error);
+ MYASSERT (tp_connection_run_until_ready (conn, TRUE, &error, NULL),
+ "");
+ MYASSERT_NO_ERROR (error);
+
+ {
+ const gchar *ids[] = {
+ "flarglybadger",
+ NULL
+ };
+ GArray *handles = NULL;
+
+ MYASSERT (tp_cli_connection_run_request_handles (conn, -1,
+ TP_HANDLE_TYPE_CONTACT, ids, &handles, &error, NULL), "");
+ MYASSERT_NO_ERROR (error);
+
+ g_array_free (handles, TRUE);
+ }
+
+ /* The bug was in cleaning up handle refs when the CM fell off the bus.
+ * Emitting "destroy" on the proxy simulates the CM falling off the bus.
+ */
+ proxy = tp_proxy_borrow_interface_by_id ((TpProxy *) conn,
+ TP_IFACE_QUARK_CONNECTION, &error);
+ MYASSERT_NO_ERROR (error);
+ g_signal_emit_by_name (proxy, "destroy");
+
+ g_idle_add_full (G_PRIORITY_LOW, no_more_idling_around, mainloop, NULL);
+
+ g_main_loop_run (mainloop);
+
+ g_object_unref (conn);
+
+ /* Make a new connection proxy so that we can call Disconnect() on the
+ * connection.
+ */
+ conn = tp_connection_new (dbus, name, conn_path, &error);
+ MYASSERT (conn != NULL, "");
+ MYASSERT_NO_ERROR (error);
+ MYASSERT (tp_connection_run_until_ready (conn, TRUE, &error, NULL), "");
+ MYASSERT_NO_ERROR (error);
+
+ MYASSERT (tp_cli_connection_run_disconnect (conn, -1, &error, NULL), "");
+ MYASSERT_NO_ERROR (error);
+
+ g_object_unref (conn);
+
+ service_conn_as_base = NULL;
+ g_object_unref (service_conn);
+ g_free (name);
+ g_free (conn_path);
+
+ g_object_unref (dbus);
+ g_main_loop_unref (mainloop);
+
+ return fail;
+}
--
1.5.6.5