[Telepathy-commits] [telepathy-mission-control/master] Channel: remove a non-functional g_return_if_fail

Will Thompson will.thompson at collabora.co.uk
Tue Dec 2 10:53:10 PST 2008


TpHandle is unsigned, so "handle >= 0" is always true.  If this was intended to
check that "handle > 0", that would be incorrect: it's valid for a channel to
have no handle.
---
 src/mcd-channel.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/mcd-channel.c b/src/mcd-channel.c
index 3491ee1..b19d919 100644
--- a/src/mcd-channel.c
+++ b/src/mcd-channel.c
@@ -464,11 +464,7 @@ _mcd_channel_set_property (GObject * obj, guint prop_id,
     case PROP_TP_CHANNEL:
 	tp_chan = g_value_get_object (val);
 	if (tp_chan)
-	{
-            g_return_if_fail (priv->handle >= 0);
- 
 	    g_object_ref (tp_chan);
-	}
 	_mcd_channel_release_tp_channel (channel, TRUE);
 	priv->tp_chan = tp_chan;
 	if (priv->tp_chan)
-- 
1.5.6.5




More information about the Telepathy-commits mailing list