[Telepathy-commits] [telepathy-qt4/master] Oggis-Review: getters are still valid after the connection has been closed after introspection completed successfully.
george.goldberg at collabora.co.uk
Tue Nov 18 12:03:36 PST 2008
The only getter I am sure about is channelType(), but should the group-stuff related getter like methods also work when channel is ReadinessClosed?
TelepathyQt4/cli-channel.cpp | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/TelepathyQt4/cli-channel.cpp b/TelepathyQt4/cli-channel.cpp
index 9c60717..2a20adf 100644
@@ -448,8 +448,10 @@ QString Channel::channelType() const
warning() << "Channel::channelType() before the channel type has been received";
else if (mPriv->readiness == ReadinessDead)
warning() << "Channel::channelType() used with readiness ReadinessDead";
- else if (mPriv->readiness == ReadinessClosed)
- warning() << "Channel::channelType() used with readiness ReadinessClosed";
+ // Channel type will still be valid if the channel has been closed after
+ // introspection completed successfully.
+ // else if (mPriv->readiness == ReadinessClosed)
+ // warning() << "Channel::channelType() used with readiness ReadinessClosed";
More information about the Telepathy-commits