[Telepathy-commits] [telepathy-salut/master] add 2 FIXME's

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Fri Nov 21 03:46:40 PST 2008


---
 lib/gibber/gibber-oob-file-transfer.c |    1 +
 src/salut-file-transfer-channel.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/gibber/gibber-oob-file-transfer.c b/lib/gibber/gibber-oob-file-transfer.c
index 8bc6217..5dc2533 100644
--- a/lib/gibber/gibber-oob-file-transfer.c
+++ b/lib/gibber/gibber-oob-file-transfer.c
@@ -411,6 +411,7 @@ create_transfer_offer (GibberOobFileTransfer *self,
   url_node = gibber_xmpp_node_add_child_with_content (query_node, "url", url);
   gibber_xmpp_node_set_attribute (url_node, "type", "file");
 
+  /* FIXME: iChat uses <query mimeType="..."> to send the mime type */
   /* FIXME: We should send a <desc> node containing the description */
 
   size = gibber_file_transfer_get_size (GIBBER_FILE_TRANSFER (self));
diff --git a/src/salut-file-transfer-channel.c b/src/salut-file-transfer-channel.c
index b6fd351..435ee26 100644
--- a/src/salut-file-transfer-channel.c
+++ b/src/salut-file-transfer-channel.c
@@ -958,6 +958,7 @@ salut_file_transfer_channel_received_file_offer (SalutFileTransferChannel *self,
       self->priv->xmpp_connection_manager , conn);
   ft = gibber_file_transfer_new_from_stanza (stanza, conn);
 
+  /* FIXME: this can lead to a remotely triggered assertion */
   g_return_if_fail (ft);
 
   g_signal_connect (ft, "error", G_CALLBACK (error_cb), self);
-- 
1.5.6.5




More information about the Telepathy-commits mailing list