[Telepathy-commits] [telepathy-salut/master] gibber_oob_file_transfer_cancel: only send the 'error' stanza is we are the receiver. It doesn't make sense to send a reply to our own IQ.

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Fri Nov 21 04:50:04 PST 2008


---
 lib/gibber/gibber-oob-file-transfer.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/lib/gibber/gibber-oob-file-transfer.c b/lib/gibber/gibber-oob-file-transfer.c
index ffa6179..bbdc793 100644
--- a/lib/gibber/gibber-oob-file-transfer.c
+++ b/lib/gibber/gibber-oob-file-transfer.c
@@ -675,6 +675,12 @@ gibber_oob_file_transfer_cancel (GibberFileTransfer *ft,
 
   if (self->priv->cancelled)
     return;
+  self->priv->cancelled = TRUE;
+
+  if (ft->direction == GIBBER_FILE_TRANSFER_DIRECTION_OUTGOING)
+    /* The OOB XEP doesn't have protocol to inform the receiver that the
+     * sender cancelled the transfer. */
+    return;
 
   stanza = gibber_xmpp_stanza_new ("iq");
   gibber_xmpp_node_set_attribute (stanza->node, "type", "error");
@@ -711,7 +717,6 @@ gibber_oob_file_transfer_cancel (GibberFileTransfer *ft,
 
   gibber_file_transfer_send_stanza (ft, stanza, NULL);
 
-  self->priv->cancelled = TRUE;
   g_object_unref (stanza);
 }
 
-- 
1.5.6.5




More information about the Telepathy-commits mailing list