[Telepathy-commits] [telepathy-salut/master] Revert "SalutTubesManager: Do not reference objects twice in set_property"

Alban Crequy alban.crequy at collabora.co.uk
Tue Nov 25 03:59:28 PST 2008


This reverts commit bacc24df0a662a31c9b62bf0da194ec16a8caaa2.

g_value_get_object() does not increment any ref count, so the commit bacc24df
is wrong.
---
 src/salut-tubes-manager.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/salut-tubes-manager.c b/src/salut-tubes-manager.c
index e451673..4936617 100644
--- a/src/salut-tubes-manager.c
+++ b/src/salut-tubes-manager.c
@@ -435,9 +435,11 @@ salut_tubes_manager_set_property (GObject *object,
         break;
       case PROP_CONTACT_MANAGER:
         priv->contact_manager = g_value_get_object (value);
+        g_object_ref (priv->contact_manager);
         break;
       case PROP_XMPP_CONNECTION_MANAGER:
         priv->xmpp_connection_manager = g_value_get_object (value);
+        g_object_ref (priv->xmpp_connection_manager);
         break;
       default:
         G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
-- 
1.5.6.5




More information about the Telepathy-commits mailing list