[Telepathy-commits] [telepathy-spec/master] ChannelRequest: in Succeeded, remove documentation of argument, and add FIXME note considering removing the argument altogether

Simon McVittie simon.mcvittie at collabora.co.uk
Fri Sep 26 08:21:23 PDT 2008


---
 spec/Channel_Request.xml |   20 +++++---------------
 1 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/spec/Channel_Request.xml b/spec/Channel_Request.xml
index a43c8ae..c61b8e5 100644
--- a/spec/Channel_Request.xml
+++ b/spec/Channel_Request.xml
@@ -128,26 +128,16 @@
       <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
         <p>The channel request has succeeded. It is no longer present,
           and further methods must not be called on it.</p>
+
+        <p>(FIXME: should this signal reference the channels that were
+          produced? If so, should they be the channels with Requested=TRUE,
+          or all the channels in the NewChannels signal?)</p>
       </tp:docstring>
 
       <arg name="Channels" type="a(oa{sv})"
         tp:type="Channel_Details[]">
         <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
-          <p>The channels that were produced. The same comments as for
-            <!--<tp:dbus-ref namespace="org.freedesktop.Telepathy">-->
-              Connection.Interface.Requests.DRAFT.RequestChannels
-            apply here.</p>
-
-          <p>After signalling success in this way, the channel
-            dispatcher will also dispatch each channel to an appropriate
-            channel handler.</p>
-
-          <tp:rationale>
-            <p>It must be <em>after</em> so channel handlers can tell
-              which channels they're being given in order to satisfy their
-              own requests (and also which requests), and which channels
-              they're being given for some other reason.</p>
-          </tp:rationale>
+          <p>(FIXME: necessary?)</p>
         </tp:docstring>
       </arg>
 
-- 
1.5.6.5




More information about the Telepathy-commits mailing list