[Telepathy-commits] [telepathy-gabble/master] add FIXME about BuddyInfo.ActivitiesChanged

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Fri Sep 26 10:02:25 PDT 2008


20080630123116-7fe3f-197a4372ddb447096e602186f0e2eb0be64a3b4f.gz
---
 src/conn-olpc.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/conn-olpc.c b/src/conn-olpc.c
index 8a2f477..336bc69 100644
--- a/src/conn-olpc.c
+++ b/src/conn-olpc.c
@@ -3157,8 +3157,8 @@ add_activities_to_view_from_node (GabbleConnection *conn,
           return LM_HANDLER_RESULT_REMOVE_MESSAGE;
         }
 
-      properties_node = lm_message_node_get_child_with_namespace (activity_node,
-          "properties", NS_OLPC_ACTIVITY_PROPS);
+      properties_node = lm_message_node_get_child_with_namespace (
+          activity_node, "properties", NS_OLPC_ACTIVITY_PROPS);
       properties = lm_message_node_extract_properties (properties_node,
           "property");
 
@@ -3202,6 +3202,8 @@ add_activities_to_view_from_node (GabbleConnection *conn,
 
       gabble_olpc_view_add_buddies (view, buddies, buddies_properties, handle);
 
+      /* FIXME: we should fire BuddyInfo.ActivitiesChanged */
+
       g_array_free (buddies, TRUE);
       g_ptr_array_free (buddies_properties, TRUE);
     }
@@ -3407,6 +3409,8 @@ remove_activities_from_view_from_node (GabbleConnection *conn,
   gabble_olpc_view_remove_activities (view, rooms);
   tp_handle_set_destroy (rooms);
 
+  /* FIXME: should fire BuddyInfo.ActivitiesChanged signal */
+
   return TRUE;
 }
 
-- 
1.5.6.5




More information about the Telepathy-commits mailing list