[Telepathy-commits] [telepathy-gabble/master] conn-olpc: add a FIXME explaining we should check the assumptions that are made about buddies and activities

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Fri Sep 26 08:17:32 PDT 2008


---
 src/conn-olpc.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/conn-olpc.c b/src/conn-olpc.c
index f87b93c..d0c281a 100644
--- a/src/conn-olpc.c
+++ b/src/conn-olpc.c
@@ -39,6 +39,13 @@
 #include "olpc-view.h"
 #include "olpc-activity.h"
 
+/* FIXME: At some point we should audit this code to check which assumptions
+ * it does about buddy and activity and if they are still relevant.
+ * For example, we currently allow the creation of activity objects which
+ * don't have an ID. I'm not sure that really make sense.
+ * Or at some place in the code, we allow user to change the ID of an existing
+ * activity object which is probably bong too. */
+
 static gboolean
 update_activities_properties (GabbleConnection *conn, const gchar *contact,
     LmMessage *msg);
-- 
1.5.6.5




More information about the Telepathy-commits mailing list