[Telepathy-commits] [telepathy-glib/master] conn_requests_offer_request: note that suppress_handler=FALSE for Ensure is questionable

Will Thompson will.thompson at collabora.co.uk
Wed Sep 17 09:54:13 PDT 2008


---
 telepathy-glib/base-connection.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/telepathy-glib/base-connection.c b/telepathy-glib/base-connection.c
index 3ffd906..7b05d7a 100644
--- a/telepathy-glib/base-connection.c
+++ b/telepathy-glib/base-connection.c
@@ -2893,6 +2893,11 @@ conn_requests_offer_request (TpBaseConnection *self,
 #if 0
     case METHOD_ENSURE_CHANNEL:
       func = tp_channel_manager_ensure_channel;
+      /* FIXME: This is questionable in the case where Yours=True is
+       *        ultimately returned to a caller; that caller will believe it
+       *        owns the channel, but the old-world dispatcher will redispatch
+       *        the channel.
+       */
       suppress_handler = FALSE;
       break;
 #endif
-- 
1.5.6.5




More information about the Telepathy-commits mailing list