[telepathy-mission-control/master] McdChannel: add new internal constructor _mcd_channel_new_undispatched

Simon McVittie simon.mcvittie at collabora.co.uk
Fri Apr 3 08:21:53 PDT 2009


This means McdConnection doesn't need to call g_object_new directly.
---
 src/mcd-channel.c    |    8 ++++++++
 src/mcd-channel.h    |    1 +
 src/mcd-connection.c |    4 +---
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/mcd-channel.c b/src/mcd-channel.c
index 0efb6b0..b1715be 100644
--- a/src/mcd-channel.c
+++ b/src/mcd-channel.c
@@ -678,6 +678,14 @@ mcd_channel_new_from_path (TpConnection *connection, const gchar *object_path,
     return channel;
 }
 
+McdChannel *
+_mcd_channel_new_undispatched (void)
+{
+    return g_object_new (MCD_TYPE_CHANNEL,
+                         "outgoing", FALSE,
+                         NULL);
+}
+
 gboolean
 _mcd_channel_create_proxy_old (McdChannel *channel, TpConnection *connection,
                                const gchar *object_path, const gchar *type,
diff --git a/src/mcd-channel.h b/src/mcd-channel.h
index 8a00ab1..3a4aa6f 100644
--- a/src/mcd-channel.h
+++ b/src/mcd-channel.h
@@ -103,6 +103,7 @@ McdChannel *mcd_channel_new_request (McdAccount *account,
                                      gint64 user_time,
                                      const gchar *preferred_handler,
                                      gboolean use_existing);
+G_GNUC_INTERNAL McdChannel *_mcd_channel_new_undispatched (void);
 
 G_GNUC_INTERNAL
 gboolean _mcd_channel_create_proxy (McdChannel *channel,
diff --git a/src/mcd-connection.c b/src/mcd-connection.c
index ecaef68..3fefc08 100644
--- a/src/mcd-connection.c
+++ b/src/mcd-connection.c
@@ -495,9 +495,7 @@ on_new_channel (TpConnection *proxy, const gchar *chan_obj_path,
          * to be used later */
         McdTmpChannelData *tcd;
 
-        channel = g_object_new (MCD_TYPE_CHANNEL,
-                                "outgoing", FALSE,
-                                NULL);
+        channel = _mcd_channel_new_undispatched ();
         tcd = g_slice_new (McdTmpChannelData);
         tcd->object_path = g_strdup (chan_obj_path);
         tcd->channel_type = g_strdup (chan_type);
-- 
1.5.6.5




More information about the telepathy-commits mailing list