[telepathy-glib/master] fd.o #22957: omit return keyword when doing a tail-call in functions returning void

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Aug 17 09:09:12 PDT 2009


Not all compilers will let you do this, apparently.

Based on a patch from Elaine Xiong <elaine.xiong at sun.com>

Reviewed-by: Will Thompson <will.thompson at collabora.co.uk>
---
 telepathy-glib/base-connection.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/telepathy-glib/base-connection.c b/telepathy-glib/base-connection.c
index a301299..5a349b8 100644
--- a/telepathy-glib/base-connection.c
+++ b/telepathy-glib/base-connection.c
@@ -3117,7 +3117,7 @@ conn_requests_create_channel (TpSvcConnectionInterfaceRequests *svc,
 {
   TpBaseConnection *self = TP_BASE_CONNECTION (svc);
 
-  return conn_requests_requestotron (self, requested_properties,
+  conn_requests_requestotron (self, requested_properties,
       METHOD_CREATE_CHANNEL, context);
 }
 
@@ -3129,7 +3129,7 @@ conn_requests_ensure_channel (TpSvcConnectionInterfaceRequests *svc,
 {
   TpBaseConnection *self = TP_BASE_CONNECTION (svc);
 
-  return conn_requests_requestotron (self, requested_properties,
+  conn_requests_requestotron (self, requested_properties,
       METHOD_ENSURE_CHANNEL, context);
 }
 
-- 
1.5.6.5



More information about the telepathy-commits mailing list