[telepathy-glib/master] tp_base_connection_change_status: don't unref and set to 0 the self-handle when connection is disconnected (fd.o #17751)
Guillaume Desmottes
guillaume.desmottes at collabora.co.uk
Tue Aug 18 11:11:37 PDT 2009
There is no reason to unref it at this stage and this make CM unable to
use the self-handle during the disconnection.
There is already code to unref it when the BaseConnection disposes so we
don't need any other change.
---
telepathy-glib/base-connection.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/telepathy-glib/base-connection.c b/telepathy-glib/base-connection.c
index a301299..61903b7 100644
--- a/telepathy-glib/base-connection.c
+++ b/telepathy-glib/base-connection.c
@@ -2687,13 +2687,6 @@ tp_base_connection_change_status (TpBaseConnection *self,
break;
case TP_CONNECTION_STATUS_DISCONNECTED:
- if (self->self_handle != 0)
- {
- tp_handle_unref (self->priv->handles[TP_HANDLE_TYPE_CONTACT],
- self->self_handle);
- self->self_handle = 0;
- }
-
/* cancel all queued channel requests that weren't already cancelled by
* the channel managers.
*/
--
1.5.6.5
More information about the telepathy-commits
mailing list