[Telepathy-commits] [telepathy-gabble/master] Remove a misleading comment about reference ownership

Will Thompson will.thompson at collabora.co.uk
Wed Feb 18 17:03:24 PST 2009

We shouldn't be relying on this kind of thing. It turns out that it can
temporarily be untrue anyway (because of things like emitting signals
taking a temporary ref) and so relying on "i unreffed this, so all my
signal handlers have been disconnected" is not a valid assumption.
 src/media-channel.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/media-channel.c b/src/media-channel.c
index 159e708..a696dba 100644
--- a/src/media-channel.c
+++ b/src/media-channel.c
@@ -2354,7 +2354,6 @@ create_stream_from_content (GabbleMediaChannel *chan, GabbleJingleContent *c)
   DEBUG ("%p: created new MediaStream %p for content '%s'", chan, stream, name);
-  /* we will own the only reference to this stream */
   g_ptr_array_add (priv->streams, stream);
   g_signal_connect (stream, "close",

More information about the telepathy-commits mailing list