[Telepathy-commits] [telepathy-qt4/master] ContactManager: Added warnings for when contacts appear on the wrong lists.

Andre Moreira Magalhaes (andrunko) andre.magalhaes at collabora.co.uk
Thu Feb 26 15:30:49 PST 2009


Added warnings when local pending contacts appear on subscribe list and
remote pending contacts appear on publish list.
---
 TelepathyQt4/Client/contact-manager.cpp |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/TelepathyQt4/Client/contact-manager.cpp b/TelepathyQt4/Client/contact-manager.cpp
index 909797c..2c74243 100644
--- a/TelepathyQt4/Client/contact-manager.cpp
+++ b/TelepathyQt4/Client/contact-manager.cpp
@@ -381,9 +381,12 @@ void ContactManager::onSubscribeChannelMembersChanged(
         const QSet<QSharedPointer<Contact> > &groupMembersRemoved,
         const Channel::GroupMemberChangeDetails &details)
 {
-    Q_UNUSED(groupLocalPendingMembersAdded);
     Q_UNUSED(details);
 
+    if (!groupLocalPendingMembersAdded.isEmpty()) {
+        warning() << "Found local pending contacts on subscribe list";
+    }
+
     foreach (QSharedPointer<Contact> contact, groupMembersAdded) {
         contact->setSubscriptionState(Contact::PresenceStateYes);
     }
@@ -404,9 +407,12 @@ void ContactManager::onPublishChannelMembersChanged(
         const QSet<QSharedPointer<Contact> > &groupMembersRemoved,
         const Channel::GroupMemberChangeDetails &details)
 {
-    Q_UNUSED(groupRemotePendingMembersAdded);
     Q_UNUSED(details);
 
+    if (!groupRemotePendingMembersAdded.isEmpty()) {
+        warning() << "Found remote pending contacts on publish list";
+    }
+
     foreach (QSharedPointer<Contact> contact, groupMembersAdded) {
         contact->setPublishState(Contact::PresenceStateYes);
     }
-- 
1.5.6.5




More information about the telepathy-commits mailing list