[Telepathy-commits] [telepathy-gabble/master] offer-muc-stream-tube-ibb: remove commented code and explain why we can't catch NewChannel signal anymore

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Tue Jan 13 02:54:11 PST 2009


---
 tests/twisted/tubes/offer-muc-stream-tube-ibb.py |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/tests/twisted/tubes/offer-muc-stream-tube-ibb.py b/tests/twisted/tubes/offer-muc-stream-tube-ibb.py
index 01fc242..914b9fe 100644
--- a/tests/twisted/tubes/offer-muc-stream-tube-ibb.py
+++ b/tests/twisted/tubes/offer-muc-stream-tube-ibb.py
@@ -100,16 +100,13 @@ def test(q, bus, conn, stream):
     bob_handle = 3
 
     # text and tubes channels are created
+    # FIXME: We can't check NewChannel signals (old API) because two of them
+    # would be fired and we can't catch twice the same signals without specifying
+    # all their arguments.
     new_sig, returned = q.expect_many(
         EventPattern('dbus-signal', signal='NewChannels'),
         EventPattern('dbus-return', method='RequestChannel'))
 
-    #path, type, handle_type, handle, supress = old_sig.args
-    #assert type == 'org.freedesktop.Telepathy.Channel.Type.Text'
-    #assert handle_type == 2 #room
-    #assert handle == handles[0]
-    #assert supress == False
-
     channels = new_sig.args[0]
     assert len(channels) == 2
 
-- 
1.5.6.5



More information about the Telepathy-commits mailing list